[pmg-devel] applied: [PATCH pmg-api v2 2/2] fix #3924: ldap: accept only valid email-address

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 6 10:12:50 CEST 2022


On 30.03.22 14:32, Markus Frank wrote:
> If a mail attribute contains special characters in ldap at the first
> line, it will be set as primary email and results in a
> "400 invalid format - value does not look like a valid email address"
> Error-Statement in the webconsole. This mostly can happen if SIP
> Addresses are in Active-Directory's proxyAddresses which begin with "SIP:".
> 
> To make the validation more strict I changed the api to use
> pmg-email-address and added a regex which looks for protocolnames (sip:)
> that could be in proxyAddresses but are not compatible and skips these
> addresses.
> 
> Signed-off-by: Markus Frank <m.frank at proxmox.com>
> ---
>  src/PMG/API2/LDAP.pm | 5 ++---
>  src/PMG/LDAPCache.pm | 8 +++++++-
>  2 files changed, 9 insertions(+), 4 deletions(-)
> 
>

applied, thanks! Fixed up a few (trailing/extra) whitespace errors and shortened
the m$ link.




More information about the pmg-devel mailing list