[pmg-devel] applied: [PATCH pmg-api] fix #2013 spamreport: remove ticket if authmode is ldap

[Thomas Lamprecht]

On 17.05.21 16:02, Stoiko Ivanov wrote:
> Currently the 'authmode' setting for the spamquarantine is not used
> anywhere. According to documentation setting it to 'ldap' should allow
> access to the quarantine only with ldap credentials.
> 
> This patch addresses the issue by not generating a quarantineticket,
> and adapting all links accordingly if the authmode is 'ldap'.
> 
> tested by changing the authmode and running
> `pmgqm send -receiver <email-address> -debug 1`
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  src/PMG/CLI/pmgqm.pm | 21 ++++++++++++++++-----
>  1 file changed, 16 insertions(+), 5 deletions(-)
> 
>

applied, with Dominiks R-b, T-b tags, thanks!

His comment was left unanswered though, just as a reminder:

> just want to comment that this is now the opposite behaviour
> of pmg <= 4 where setting authmode to ldap would not
> change the template, but not accept quarantine tickets anymore
> (which we should *probably* also do, since there may be
> some valid tickets around; but this can be a separate patch) 

(no hard feelings regarding this from my side, as said, just a reminder
to ensure it did not get lost, or was discussed off-list and the result of
that did not made it to the list or the like)