<html><head>
<style id="css_styles" type="text/css"><!--blockquote.cite { margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc }
blockquote.cite2 {margin-left: 5px; margin-right: 0px; padding-left: 10px; padding-right:0px; border-left: 1px solid #cccccc; margin-top: 3px; padding-top: 0px; }
a img { border: 0px; }
table { border-collapse: collapse; }
li[style='text-align: center;'], li[style='text-align: center; '], li[style='text-align: right;'], li[style='text-align: right; '] { list-style-position: inside;}
body { font-family: Helvetica; font-size: 9pt; }
.quote { margin-left: 1em; margin-right: 1em; border-left: 5px #ebebeb solid; padding-left: 0.3em; }
a.em-mention[href] { text-decoration: none; color: inherit; border-radius: 3px; padding-left: 2px; padding-right: 2px; background-color: #e2e2e2; }
--></style></head>
<body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;"><div>Hi,</div><div><br /></div><div id="x8ab9425d752e430" class="plain"><blockquote cite="D6D3QC6Y5H4S.1QHYHPHXK6RVR@proxmox.com" type="cite" class="cite2">
<div class="plain_line">Sure, just be aware that you have to manually delete the key before</div>
<div class="plain_line">restarting the PBS. Upgrading alone won't affect the key. Ideally you'd</div>
<div class="plain_line">test this before rolling it out, if you can</div></blockquote><span><div id="x8ab9425d752e430" class="plain"><span><br /></span></div>Yes, we will keep that in mind.</span></div><div id="x8ab9425d752e430" class="plain"><blockquote cite="D6D3QC6Y5H4S.1QHYHPHXK6RVR@proxmox.com" type="cite" class="cite2"><div class="plain_line"> </div>
<div class="plain_line">Possible, yes, that would depend on your configuration. Are all of these</div>
<div class="plain_line">datastores defined with a backing device? Because if not, than this</div>
<div class="plain_line">should be fairly fast (as in, this should not actually touch the disks).</div>
<div class="plain_line">If they are, then yes this could be slow as each store would trigger at</div>
<div class="plain_line">least 2 stat calls afaict.</div></blockquote><span><div id="x8ab9425d752e430" class="plain"><span>They are all ZFS based, so not sure if that helps.</span></div><div id="x8ab9425d752e430" class="plain"><br /></div></span><blockquote cite="D6D3QC6Y5H4S.1QHYHPHXK6RVR@proxmox.com" type="cite" class="cite2">
<div class="plain_line">In any case, it should be fine to move the `mount_status` check after</div>
<div class="plain_line">the `if allowed || allow_id` check from what i can tell. Not sure why</div>
<div class="plain_line">we'd need to check the mount_status for a datastore we won't include in</div>
<div class="plain_line">the resulsts anyway. Same goes for parsing the store config imo. Send a</div>
<div class="plain_line">patch for that [1].</div>
<div class="plain_line"> </div>
<div class="plain_line">[1]: <a href="https://lore.proxmox.com/pbs-devel/20241216115044.208595-1-s.sterz@proxmox.com/T/#u" class="__cef_visited">https://lore.proxmox.com/pbs-devel/20241216115044.208595-1-s.sterz@proxmox.com/T/#u</a></div></blockquote><span><div id="x8ab9425d752e430" class="plain"><span><br /></span></div>This might help, at least. </span>Thanks!</div><div id="x8ab9425d752e430" class="plain"><span><br /></span></div><div id="x8ab9425d752e430" class="plain"><span>So looking further into this, I noticed an average of ~ 70 calls per second on:</span></div><div id="x8ab9425d752e430" class="plain"><span>/api2/json/admin/datastore/.+/status </span></div><div id="x8ab9425d752e430" class="plain"><span><br /></span></div><div id="x8ab9425d752e430" class="plain">I think that is `pub async fn status()` in that same file, right? Nothing much to tune there.</div><div id="x8ab9425d752e430" class="plain"><br /></div><div id="x8ab9425d752e430" class="plain">Thanks again, I will keep you posted on the progress after our maintenance window.</div><div id="x8ab9425d752e430" class="plain"><div><br /></div><div id="signature_old" style="clear:both"><div style="margin: 0px; padding: 0px; box-sizing: content-box;">— </div><div style="margin: 0px; padding: 0px; box-sizing: content-box;">Mark Schouten</div><div style="margin: 0px; padding: 0px; box-sizing: content-box;">CTO, Tuxis B.V.</div><div style="margin: 0px; padding: 0px; box-sizing: content-box;">+31 318 200208 / mark@tuxis.nl</div></div><br style="clear:both" /></div><div id="x8ab9425d752e430" class="plain"><blockquote cite="D6D3QC6Y5H4S.1QHYHPHXK6RVR@proxmox.com" type="cite" class="cite2">
</blockquote></div>
</body></html>