<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>On 10/16/23 12:04, Thomas Lamprecht wrote:</p>
<blockquote type="cite"
cite="mid:1d8ff790-3e6c-435d-a58d-5a7ab32245fb@proxmox.com">[..]<span
style="white-space: pre-wrap">
</span>
<pre class="moz-quote-pre" wrap="">To clarify, I'd explicitly only left-align those spinners for when
used as job running spinners, not for loading – and IIRC we do not
have any per-cell or per-row loading indicators anyway, as we always
load all data of a grid at once (or at least fake doing so), but never
row or even cell-wise.</pre>
</blockquote>
Oh, ok, got it.<span style="white-space: pre-wrap">
</span><span style="white-space: pre-wrap">
</span>
<blockquote type="cite"
cite="mid:1d8ff790-3e6c-435d-a58d-5a7ab32245fb@proxmox.com">
<pre class="moz-quote-pre" wrap="">So moving this new alignment behavior into its own class, that derives
from the ExtJS one, seems more reasonable to avoid odd rendering issues
for the cases where the left-alignment isn't desired.
If we then add a text to that is an independent decision, but it surely
wouldn't hurt accessibility.
</pre>
</blockquote>
Ok, so I think I'll move the current `x-grid-row-loading` class to
the<br>
`proxmox-widget-toolkit/src/css/ext-6-pmx.css` file and create a new<br>
class `x-grid-row-loading-left` (with the 10px margin left). I'll
also<br>
have to edit the `proxmox-dark/*.scss` files so that the logo is
shown<br>
correctly in the darkmode. To add the text I would simply return a
`<span>`<br>
tag with a margin left of 20px (more or less, to make place for the
icon)<br>
and have the translated text as a content.<br>
<p>Returning the icon directly as a `<img>` tag isn't that
simple, I'd had to<br>
attach the whole styling + the conditional dark mode stuff.<br>
<br>
LMK what you think!<br>
</p>
</body>
</html>